Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: small improvements to test settings #3577

Merged
merged 69 commits into from
Jan 7, 2025
Merged

refactor: small improvements to test settings #3577

merged 69 commits into from
Jan 7, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 26, 2024 •
edited
Loading

Description

As the title. Let's explore why the tests are taking so long since #3268

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner November 26, 2024 10:57
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 26, 2024 10:57
@germa89 germa89 self-assigned this Nov 26, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Nov 26, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 48.38710% with 16 lines in your changes missing coverage. Please review.

Project coverage is 87.08%. Comparing base (4f75f6a) to head (38fc0fb).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3577      +/-   ##
==========================================
- Coverage   87.18%   87.08%   -0.11%     
==========================================
  Files         187      187              
  Lines       14660    14679      +19     
==========================================
+ Hits        12782    12783       +1     
- Misses       1878     1896      +18

@github-actions github-actions bot added the documentation Documentation related (improving, adding, etc) label Nov 27, 2024
@germa89 germa89 mentioned this pull request Dec 13, 2024
Merged
10 tasks
@germa89
Copy link
Collaborator Author

germa89 commented Dec 13, 2024 •
edited
Loading

I'm renaming this PR.

The original issue #3591 was fixed in #3608

I am extracting the timeout option to #3621 so we separate concerns in different PRs.

However, there is a benefitial refactoring in the PR so I'm renaming it.

@germa89 germa89 changed the title ci: adding timeout to each test refactor: small improvements to test settings Dec 13, 2024
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Dec 13, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Dec 13, 2024

To be merged after:

@germa89
Copy link
Collaborator Author

germa89 commented Dec 13, 2024

@pyansys-ci-bot LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 marked this pull request as ready for review December 16, 2024 09:18
@germa89 germa89 enabled auto-merge (squash) December 19, 2024 17:35
MaxJPRey
MaxJPRey reviewed Dec 24, 2024
View reviewed changes
tests/test_xpl.py Outdated Show resolved Hide resolved
MaxJPRey
MaxJPRey reviewed Dec 24, 2024
View reviewed changes
tests/test_xpl.py Outdated Show resolved Hide resolved
germa89
germa89 commented Jan 7, 2025
View reviewed changes
src/ansys/mapdl/core/post.py Outdated Show resolved Hide resolved
germa89
germa89 commented Jan 7, 2025
View reviewed changes
src/ansys/mapdl/core/post.py Outdated Show resolved Hide resolved
@germa89 germa89 merged commit 7b544b4 into main Jan 7, 2025
62 of 65 checks passed
@germa89 germa89 deleted the ci/add-timeout-to-tests branch January 7, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc enhancement Improve any current implemented feature maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@germa89 @MaxJPRey @pyansys-ci-bot